kaffa/XDP-Firewall
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Organize codeand potentially increase performance in XDP program.

Browse Source
This commit is contained in:
Christian Deacon
2025-02-23 07:15:37 -05:00
parent 4e7c563274
commit e5c11bb20c
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/xdp/prog.c
View File

@@ -246,7 +246,7 @@ int xdp_prog_main(struct xdp_md *ctx)
UpdateIpStats(&pps, &bps, iph->saddr, src_port, protocol, pkt_len, now); UpdateIpStats(&pps, &bps, iph->saddr, src_port, protocol, pkt_len, now);
} }
for (u8 i = 0; i < MAX_FILTERS; i++) for (int i = 0; i < MAX_FILTERS; i++)
{ {
u32 key = i; u32 key = i;

4
src/xdp/utils/helpers.c
View File

@@ -8,8 +8,8 @@
* @param cidr The CIDR range. * @param cidr The CIDR range.
* *
* @return 1 on yes, 0 on no. * @return 1 on yes, 0 on no.
*/ */
static __always_inline u8 IsIpInRange(u32 src_ip, u32 net_ip, u8 cidr) static __always_inline int IsIpInRange(u32 src_ip, u32 net_ip, u8 cidr)
{ {
return !((src_ip ^ net_ip) & htonl(0xFFFFFFFFu << (32 - cidr))); return !((src_ip ^ net_ip) & htonl(0xFFFFFFFFu << (32 - cidr)));
} }

2
src/xdp/utils/helpers.h
View File

@@ -28,7 +28,7 @@
#define memcpy(dest, src, n) __builtin_memcpy((dest), (src), (n)) #define memcpy(dest, src, n) __builtin_memcpy((dest), (src), (n))
#endif #endif
static __always_inline u8 IsIpInRange(u32 src_ip, u32 net_ip, u8 cidr); static __always_inline int IsIpInRange(u32 src_ip, u32 net_ip, u8 cidr);
// NOTE: We include the C source file below because we can't link object files which includes the function logic into the main XDP program because we need to ensure the function is always inlined for performance which doesn't work with linked objects. // NOTE: We include the C source file below because we can't link object files which includes the function logic into the main XDP program because we need to ensure the function is always inlined for performance which doesn't work with linked objects.
// More Info: https://stackoverflow.com/questions/24289599/always-inline-does-not-work-when-function-is-implemented-in-different-file // More Info: https://stackoverflow.com/questions/24289599/always-inline-does-not-work-when-function-is-implemented-in-different-file

4
src/xdp/utils/rl.c
View File

@@ -12,7 +12,7 @@
* @param now The current time since boot in nanoseconds.alignas * @param now The current time since boot in nanoseconds.alignas
* *
* @return void * @return void
*/ */
static __always_inline void UpdateIpStats(u64 *pps, u64 *bps, u32 ip, u16 port, u8 protocol, u16 pkt_len, u64 now) static __always_inline void UpdateIpStats(u64 *pps, u64 *bps, u32 ip, u16 port, u8 protocol, u16 pkt_len, u64 now)
{ {
#ifdef USE_FLOW_RL #ifdef USE_FLOW_RL
@@ -77,7 +77,7 @@ static __always_inline void UpdateIpStats(u64 *pps, u64 *bps, u32 ip, u16 port,
* @param now The current time since boot in nanoseconds.alignas * @param now The current time since boot in nanoseconds.alignas
* *
* @return void * @return void
*/ */
static __always_inline void UpdateIp6Stats(u64 *pps, u64 *bps, u128 *ip, u16 port, u8 protocol, u16 pkt_len, u64 now) static __always_inline void UpdateIp6Stats(u64 *pps, u64 *bps, u128 *ip, u16 port, u8 protocol, u16 pkt_len, u64 now)
{ {
#ifdef USE_FLOW_RL #ifdef USE_FLOW_RL